Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom marshaller for FRBACEndpointPermission #619

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Conversation

GGabriele
Copy link
Collaborator

Paired with Kong/go-kong#148

Sample kong.yaml.txt

$ ./deck sync --rbac-resources-only
creating rbac-role workspace-super-admin
creating rbac-role workspace-read-only
creating rbac-role workspace-portal-admin
creating rbac-role workspace-admin
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/developers
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/kong
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/rbac/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/files/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/developers/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/files
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/rbac/*/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/rbac/*/*/*/*/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/rbac/*/*/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/rbac/*/*/*/*
creating rbac-endpoint-permission 0a457005-b3c7-4a43-ac33-b5541514b4aa-workspace1-/workspaces/workspace1
creating rbac-endpoint-permission 5738f6fd-7916-4e90-b188-2806da6d2d4c-workspace1-*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-/rbac/*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-/rbac/*/*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-/rbac/*/*/*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-/rbac/*/*/*/*
creating rbac-endpoint-permission 8c79d298-7400-4f4f-b7ca-22981eab950c-workspace1-/rbac/*/*/*/*/*
creating rbac-endpoint-permission b1232e42-b166-4cfa-a3ac-bffa35eda9fa-workspace1-*
Summary:
  Created: 23
  Updated: 0
  Deleted: 0

$ ./deck sync --rbac-resources-only
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

$ ./deck diff --rbac-resources-only
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

$ ./deck dump --rbac-resources-only --workspace workspace1 --yes

$ ./deck diff --rbac-resources-only
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

$ ./deck sync --rbac-resources-only
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

@codecov-commenter
Copy link

Codecov Report

Merging #619 (0cefeaf) into main (9892fdb) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   45.56%   45.43%   -0.13%     
==========================================
  Files          74       74              
  Lines        8450     8474      +24     
==========================================
  Hits         3850     3850              
- Misses       4241     4265      +24     
  Partials      359      359              
Impacted Files Coverage Δ
file/types.go 63.32% <0.00%> (-5.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9892fdb...0cefeaf. Read the comment docs.

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the change to kong.yaml? I forget how we're actually using that, but the change appears to remove all resources currently present in it and replaces them with a set of RBAC resources. Should those instead be concatenated?

Other than that looks fine pending a go-kong release and updated module.

@GGabriele
Copy link
Collaborator Author

What's with the change to kong.yaml? I forget how we're actually using that, but the change appears to remove all resources currently present in it and replaces them with a set of RBAC resources. Should those instead be concatenated?

Ops, I included that by mistake. Cleaned it now.

@rainest rainest merged commit 5b9615a into main Mar 25, 2022
@rainest rainest deleted the rbac_actions branch March 25, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants