-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add custom marshaller for FRBACEndpointPermission #619
Conversation
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 45.56% 45.43% -0.13%
==========================================
Files 74 74
Lines 8450 8474 +24
==========================================
Hits 3850 3850
- Misses 4241 4265 +24
Partials 359 359
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the change to kong.yaml? I forget how we're actually using that, but the change appears to remove all resources currently present in it and replaces them with a set of RBAC resources. Should those instead be concatenated?
Other than that looks fine pending a go-kong release and updated module.
Ops, I included that by mistake. Cleaned it now. |
Paired with Kong/go-kong#148
Sample kong.yaml.txt