-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release Fat/Universal binaries for macOS #585
Conversation
Codecov Report
@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 51.15% 51.15%
=======================================
Files 73 73
Lines 8009 8009
=======================================
Hits 4097 4097
Misses 3542 3542
Partials 370 370 Continue to review full report at Codecov.
|
Did you test this on M1 and x86 both? |
Yep correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking @GGabriele's word on this one.
I tested this as follows:
goreleaser release --snapshot --rm-dist
locally to generate the artifacts and include them in a new releasedist/deck.rb
file to point brew at my repo instead ofKong/deck
*_darwin_all.tar.gz
"universal" artifact)Verify everything looks good:
#512