Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release Fat/Universal binaries for macOS #585

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

GGabriele
Copy link
Collaborator

I tested this as follows:

  • on my forked repo, I created and pushed a new tag to simulate a release
  • I ran goreleaser release --snapshot --rm-dist locally to generate the artifacts and include them in a new release
  • modified the generated dist/deck.rb file to point brew at my repo instead of Kong/deck
  • use the local file with brew (note this is pulling the *_darwin_all.tar.gz "universal" artifact)
$ brew install dist/deck.rb
Error: Failed to load cask: dist/deck.rb
Cask 'deck' is unreadable: wrong constant name #<Class:0x000000015b96e108>
Warning: Treating dist/deck.rb as a formula.
==> Downloading https://github.com/GGabriele/deck/releases/download/v1.10.0-testing/deck_v1.10.0-testing_darwin_all.tar.gz
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/412574371/847dd173-643c-409f-bd94-dda41226d735?X-Amz-Al
######################################################################## 100.0%
Warning: deck 1.10.0 is available and more recent than version v1.10.0-testing.
🍺  /opt/homebrew/Cellar/deck/v1.10.0-testing: 6 files, 21.2MB, built in 2 seconds
==> Running `brew cleanup deck`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /Users/ggerbino/Library/Caches/Homebrew/deck--v1.10.0-testing.tar.gz... (7.6MB)

Verify everything looks good:

$ which deck
/opt/homebrew/bin/deck

$ ls -l /opt/homebrew/bin/deck
lrwxr-xr-x  1 ggerbino  admin  39 Feb  9 22:45 /opt/homebrew/bin/deck -> ../Cellar/deck/v1.10.0-testing/bin/deck

$ deck ping
Successfully connected to Kong!
Kong version:  2.7.0.0-enterprise-edition

#512

@GGabriele GGabriele requested a review from a team as a code owner February 9, 2022 21:49
@codecov-commenter
Copy link

Codecov Report

Merging #585 (c1c4016) into main (b6d835c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   51.15%   51.15%           
=======================================
  Files          73       73           
  Lines        8009     8009           
=======================================
  Hits         4097     4097           
  Misses       3542     3542           
  Partials      370      370           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d835c...c1c4016. Read the comment docs.

@hbagdi
Copy link
Member

hbagdi commented Feb 10, 2022

Did you test this on M1 and x86 both?

@GGabriele
Copy link
Collaborator Author

Did you test this on M1 and x86 both?

Yep correct

Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking @GGabriele's word on this one.

@hbagdi hbagdi merged commit 299542a into main Feb 10, 2022
@hbagdi hbagdi deleted the universal_bin branch February 10, 2022 22:12
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this pull request Feb 17, 2022
renovate bot pushed a commit to aquaproj/aqua-registry that referenced this pull request Feb 17, 2022
This was referenced Feb 17, 2022
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants