Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*) add 1.9.0 changes #535

Merged
merged 8 commits into from
Dec 9, 2021
Merged

docs(*) add 1.9.0 changes #535

merged 8 commits into from
Dec 9, 2021

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Dec 1, 2021

Add 1.8.3 changes and release instructions.

Small, but we haven't had a patch release in quite a while, and the error return is something we want in KIC sooner or later.

I also want to confirm the new CI stuff works in the actual deck repo and confirm if there's something I forgot that still requires manual work.

Added release instructions since we'd apparently forgotten to ever take them out of a Google Doc, and they've been stable for a while now.

@rainest rainest requested a review from a team as a code owner December 1, 2021 23:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #535 (6b1258b) into main (65b1bee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   51.98%   51.98%           
=======================================
  Files          73       73           
  Lines        7714     7714           
=======================================
  Hits         4010     4010           
  Misses       3354     3354           
  Partials      350      350           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b1bee...6b1258b. Read the comment docs.

Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, each of these changes modifies existing behavior that may potentially be relied upon (per Hyrum's law).

Therefore I suggest that we bump the minor version number and release this as 1.9.0, and replace "Fixed" with "Breaking changes" in the changelog.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the last round, I'm now convinced that the select-tags change can be deemed a fix; I don't feel very comfortable doing so for the semantic change of error handling, but (as discussed in the inline comment) the impact is minimal (this is becoming an academic discussion) and not worth agonizing over it, so let it be.

Some minor release procedure comments attached.

CHANGELOG.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
Travis Raines and others added 2 commits December 8, 2021 09:00
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
@rainest rainest changed the title docs(*) add 1.8.3 changes docs(*) add 1.9.0 changes Dec 8, 2021
mflendrich
mflendrich previously approved these changes Dec 9, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
@rainest rainest merged commit cdda3c5 into main Dec 9, 2021
@rainest rainest deleted the release/1.8.3 branch December 9, 2021 23:34
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
* docs(*) add 1.8.3 changes

Co-authored-by: Michał Flendrich <michal@flendrich.pro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants