-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reader) handle _transform field #520
Conversation
64cc681
to
29a1c7e
Compare
Testing the positive case for
|
29a1c7e
to
5edd035
Compare
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 50.47% 50.67% +0.20%
==========================================
Files 72 72
Lines 7870 7876 +6
==========================================
+ Hits 3972 3991 +19
+ Misses 3549 3535 -14
- Partials 349 350 +1
Continue to review full report at Codecov.
|
132546d
to
67b9c81
Compare
Handle the Kong state _transform field, which indicates whether data should pass through applicable transforms when imported into Kong. As deck passes data through the admin API, it will always pass through transforms. deck rejects the state if _transform=false, as it cannot satisfy this request.
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
@kikito Can you verify if the understanding of "_transform" here is indeed correct or not? |
@rainest can you squash all your commits into a single commit? We are good to merge after that. |
@hbagdi auto-merge is now set to squash mode and I've removed irrelevant commit headers from the body. It'll merge once you approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but disabled auto-merge so as to prevent the discussion on comments from being missed.
Handle the Kong state _transform field, which indicates whether data should pass through applicable transforms when imported into Kong. As deck passes data through the admin API, it will always pass through transforms. deck rejects the state if _transform=false, as it cannot satisfy this request. Co-authored-by: Michał Flendrich <michal@flendrich.pro>
Handle the Kong state _transform field, which indicates whether data should pass through applicable transforms when imported into Kong. As deck passes data through the admin API, it will always pass through transforms. deck rejects the state if _transform=false, as it cannot satisfy this request.
AFAIK, we need take no additional action for
true
, and that is the default per https://docs.konghq.com/gateway-oss/2.6.x/db-less-and-declarative-config/#the-declarative-configuration-format. Rejectingfalse
outright instead of warning since that should indicate that the file contains transformed/encrypted content, and running it through transforms again will not result in the intended config.Fix #510