mTLS Kong Admin API authentication support (#508) #509
Conversation
Feature request proposal
|
|
Apply feedback.
|
Do you have advises about testing ? I will update to PR to add coverage. |
Co-authored-by: Harry <harrybagdi@gmail.com>
Co-authored-by: Harry <harrybagdi@gmail.com>
Co-authored-by: Harry <harrybagdi@gmail.com>
Co-authored-by: Harry <harrybagdi@gmail.com>
Review comments.
Review due to comments.
Review formatting.
There was a problem hiding this comment.
LGTM once these changes are taken care of.
@GGabriele can take care of the merge.
| @@ -97,6 +97,10 @@ type KongClientConfig struct { | |||
| Timeout int | |||
|
|
|||
| CookieJarPath string | |||
|
|
|||
| TLSClientCert string | |||
There was a problem hiding this comment.
Unnecessary string conversions. Please change both of these types to []byte and update the code accordingly.
There was a problem hiding this comment.
Seem's not consistent with the CA certificate management ?
There was a problem hiding this comment.
That should have been a []byte as well but oh well, no biggie.
Co-authored-by: Harry <harrybagdi@gmail.com>
According comments.
|
@ludovic-pourrat Linter unhappy. |
|
Oups, too quick sorry for this 😂 |
Try to fix linter.
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 51.88% 51.27% -0.61%
==========================================
Files 73 73
Lines 7742 7943 +201
==========================================
+ Hits 4017 4073 +56
- Misses 3375 3501 +126
- Partials 350 369 +19
Continue to review full report at Codecov.
|
Feature request proposal related to mTLS Kong Admin API authentication support #508