Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct formats where conversion is allowed #460

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Jul 12, 2021

Previously, KongGateway was listed in --to and Konnect was listed in
--to, which wasn't supported.
This fixes the documentation so that the user isn't confused anymore.

Previously, KongGateway was listed in --to and Konnect was listed in
--to, which wasn't supported.
This fixes the documentation so that the user isn't confused anymore.
@hbagdi hbagdi requested a review from a team as a code owner July 12, 2021 15:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #460 (bc00b6d) into main (5ce9ef2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   50.28%   50.29%   +0.01%     
==========================================
  Files          72       72              
  Lines        5698     5700       +2     
==========================================
+ Hits         2865     2867       +2     
  Misses       2501     2501              
  Partials      332      332              
Impacted Files Coverage Δ
cmd/convert.go 42.30% <100.00%> (+4.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce9ef2...bc00b6d. Read the comment docs.

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO including the []convert.Format{...} inline with the Sprint would be more readable if we don't need to reuse the format lists, but that's a minor style nit that doesn't really matter--the variable definitions are close by, so vov.

@hbagdi hbagdi merged commit 2829fa7 into main Jul 12, 2021
@hbagdi hbagdi deleted the fix/convert-documentation branch July 12, 2021 20:24
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Previously, KongGateway was listed in --to and Konnect was listed in
--to, which wasn't supported.
This fixes the documentation so that the user isn't confused anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants