Set client timeout https://github.com/Kong/deck/issues/449

[fjaenni]

#449

[CLAassistant]

All committers have signed the CLA.

[mmorel-35]

Does it really needs to be a public variable? Lowercase shall be enough?

[rainest]

@fjaenni some minor linter issues that need addressing.

I'd recommend placing the default timeout in the flag (rootCmd.PersistentFlags().Int("timeout", 10, ...)) and using that value throughout. Otherwise it's a bit confusing that the value shown in help doesn't reflect the actual default timeout--it suggests that the default is instead no timeout.

[fjaenni]

@fjaenni some minor linter issues that need addressing.

I'd recommend placing the default timeout in the flag (rootCmd.PersistentFlags().Int("timeout", 10, ...)) and using that value throughout. Otherwise it's a bit confusing that the value shown in help doesn't reflect the actual default timeout--it suggests that the default is instead no timeout.

hi,
I agree, I thought about doing it like this but finally ...
Thank you so much

[codecov-commenter]

Codecov Report

Merging #450 (143a863) into main (704b7ca) will increase coverage by 0.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   50.29%   50.30%   +0.01%     
==========================================
  Files          72       72              
  Lines        5687     5693       +6     
==========================================
+ Hits         2860     2864       +4     
- Misses       2496     2498       +2     
  Partials      331      331              

Impacted Files	Coverage Δ
utils/types.go	22.22% <0.00%> (-0.32%)	⬇️
cmd/root.go	58.87% <80.00%> (+0.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704b7ca...143a863. Read the comment docs.