fix: set description to null to reset description #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konnect API's behavior seems to be that if one sends a PATCH request without an explicit `null`, that property is not reset to empty. After removal of `omitempty`, deleting `description` field from the state file correctly updates the description in Konnect.
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 52.57% 52.57%
=======================================
Files 60 60
Lines 4875 4875
=======================================
Hits 2563 2563
Misses 2014 2014
Partials 298 298 Continue to review full report at Codecov.
|
rainest
approved these changes
Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Konnect API's behavior seems to be that if one sends a PATCH request without
an explicit
null, that property is not reset to empty.After removal of
omitempty, deletingdescriptionfield from thestate file correctly updates the description in Konnect.