fix(state) drop index on target.Target #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target.Target represents an IP address or a DNS name in Kong. These can be same across different Upstreams. Drop the unique index on Target resource for this reason. This is similar to the fix applies to ServiceVersion resource in cf44212. The test has been updated to remove insertion of Upstream which doesn't add in value. Fix #233
mflendrich
approved these changes
Mar 8, 2021
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
target.Target represents an IP address or a DNS name in Kong. These can be same across different Upstreams. Drop the unique index on Target resource for this reason. This is similar to the fix applies to ServiceVersion resource in cf44212. The test has been updated to remove insertion of Upstream which doesn't add in value. Fix #233
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
target.Target represents an IP address or a DNS name in Kong. These can be same across different Upstreams. Drop the unique index on Target resource for this reason. This is similar to the fix applies to ServiceVersion resource in 512d53f. The test has been updated to remove insertion of Upstream which doesn't add in value. Fix #233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target.Target represents an IP address or a DNS name in Kong. These can
be same across different Upstreams.
Drop the unique index on Target resource for this reason.
This is similar to the fix applies to ServiceVersion resource in
cf44212.
The test has been updated to remove insertion of Upstream which doesn't
add in value.
Fix #233