Fix --verbose #243
Merged
Fix --verbose #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally set the verbosity config after loading it from the --verbose flag. #225 grouped that config set with other config settings, before loading the --verbose flag value. As a result, deck always used the default verbosity. This change moves the --verbose flag load above those settings, restoring the ability to control verbosity.
|
The issue with
Similarly, See 666ce73, which builds on top of this PR and streamlines handling of these parameters, that is:
I recommend cherry-picking that commit into this PR if that looks good to you. |
|
|
mflendrich
approved these changes
Dec 11, 2020
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
* fix(cmd) restore verbosity We originally set the verbosity config after loading it from the --verbose flag. #225 grouped that config set with other config settings, before loading the --verbose flag value. As a result, deck always used the default verbosity. This change moves the --verbose flag load above those settings, restoring the ability to control verbosity. * refactor(flags): simplify verbose and noColor Co-authored-by: Michał Flendrich <michal@flendrich.pro>
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
* fix(cmd) restore verbosity We originally set the verbosity config after loading it from the --verbose flag. #225 grouped that config set with other config settings, before loading the --verbose flag value. As a result, deck always used the default verbosity. This change moves the --verbose flag load above those settings, restoring the ability to control verbosity. * refactor(flags): simplify verbose and noColor Co-authored-by: Michał Flendrich <michal@flendrich.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally set the verbosity config after loading it from the
--verbose flag. #225's changes to fix workspace issues grouped that config set with other config settings, before loading the--verboseflag value. As a result, deck always uses the default verbosity.This change moves the
--verboseflag load above those settings, restoring the ability to control verbosity.Originally reported internally in FTI-2144. FWIW, no-color is still after everything in that block, but that doesn’t appear to matter/it’s still applied correctly in 1.2.3. Didn’t dig into how that works, but it doesn’t appear that needs a similar fix, so left it alone.