fix(file) convert yaml to JSON #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
force-pushed
the
fix/144
branch
2 times, most recently
from
421ea6c
to
a3e2b5e
Compare
mflendrich
approved these changes
Nov 9, 2020
file/readfile.go
Outdated
| // yamlUnmarshal is a wrapper around yaml.Unmarshal to ensure that the right | ||
| // yaml package is in use. The verification for this is done using a test. | ||
| func yamlUnmarshal(bytes []byte, v interface{}) error { | ||
| return yaml.Unmarshal(bytes, v) |
There was a problem hiding this comment.
optional suggestion: import by a nonstardard name, e.g. ghodssyaml, to make it harder for goimports to tamper with this import
file/readfile.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &content, nil | ||
| } | ||
|
|
||
| // yamlUnmarshal is a wrapper around yaml.Unmarshal to ensure that the right | ||
| // yaml package is in use. The verification for this is done using a test. |
There was a problem hiding this comment.
please explain (to the future reader) what behavior is desired (and what is undesired) from this function.
`go-yaml` marshals into `map[interface{}]interface{}`.
This change ensures that `map[interface{}]interface{}` is converted into
`map[string]interface{}` RECURSIVELY.
See #144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-yamlmarshals intomap[interface{}]interface{}.This change ensures that
map[interface{}]interface{}is converted intomap[string]interface{}RECURSIVELY.This patch needs tests before it can be merged.Added a test.See #144