-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apiops): add host-based namespacing #1241
Conversation
CLI help and examples still need to be added. |
CLI text added, ready for review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 21.52% 21.69% +0.17%
==========================================
Files 53 53
Lines 5385 5452 +67
==========================================
+ Hits 1159 1183 +24
- Misses 4135 4176 +41
- Partials 91 93 +2 ☔ View full report in Codecov by Sentry. |
Is this PR still pending test additions for the new flags and features? |
The CLI unfortunately doesn't have any tests, there was an attempt a long time ago, but it was abandoned and never restarted. |
This completes the namespace feature, by adding the hostbased namespacing to the existing path-based namespacing. See Kong/go-apiops#129 (comment) for an explanation.
This completes the namespace feature, by adding the host-based
namespacing to the existing path-based namespacing.
See Kong/go-apiops#129 (comment)
for an explanation.