Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(go-apiops): bump to 0.1.26, adding O2K security #1119

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 28, 2023

Adds generating OIDC plugins from OpenAPI Security directives

This also makes go-apiops commands update the cli warnings, hence merging this PR should be aligned with;

@Tieske Tieske requested a review from a team November 28, 2023 14:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2cc6fd8) 5.91% compared to head (3a5d574) 5.90%.

Files Patch % Lines
cmd/file_openapi2kong.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1119      +/-   ##
========================================
- Coverage   5.91%   5.90%   -0.02%     
========================================
  Files         31      31              
  Lines       3144    3150       +6     
========================================
  Hits         186     186              
- Misses      2948    2954       +6     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rspurgeon
Copy link
Collaborator

We discussed making this Draft so we could evaluate the UX and behavior before releasing. Shouldn't this be marked Draft to avoid merge?

@Tieske Tieske marked this pull request as draft November 28, 2023 15:33
@Tieske Tieske changed the title deps(go-apiops): bump to 0.1.25, adding O2K security deps(go-apiops): bump to 0.1.26, adding O2K security Dec 2, 2023
@Tieske
Copy link
Member Author

Tieske commented Dec 20, 2023

@rspurgeon is this good to go?

@rspurgeon
Copy link
Collaborator

@Tieske I defer to the development team if this feature is sufficiently validated. If so, yes, please merge and release.

@Tieske Tieske marked this pull request as ready for review December 21, 2023 12:09
Adds generating OIDC plugins from OpenAPI Security directives
@Tieske Tieske merged commit 1a9cd50 into main Jan 8, 2024
35 checks passed
@Tieske Tieske deleted the deps/go-apiops branch January 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants