Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): add analytics for local operations #1051

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat(analytics): add analytics for local operations #1051

merged 1 commit into from
Oct 18, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Oct 10, 2023

Jira: APIOPS-86

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1b8317a) 33.58% compared to head (3b4af4c) 33.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   33.58%   33.55%   -0.04%     
==========================================
  Files         101      101              
  Lines       12430    12442      +12     
==========================================
  Hits         4175     4175              
- Misses       7848     7860      +12     
  Partials      407      407              
Files Coverage Δ
cmd/file_addplugins.go 0.00% <0.00%> (ø)
cmd/file_addtags.go 0.00% <0.00%> (ø)
cmd/file_listtags.go 0.00% <0.00%> (ø)
cmd/file_merge.go 0.00% <0.00%> (ø)
cmd/file_openapi2kong.go 0.00% <0.00%> (ø)
cmd/file_patch.go 0.00% <0.00%> (ø)
cmd/file_removetags.go 0.00% <0.00%> (ø)
cmd/file_render.go 0.00% <0.00%> (ø)
cmd/common.go 3.94% <0.00%> (-0.03%) ⬇️
cmd/file_convert.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rspurgeon
Copy link
Collaborator

Are there specific reasons we would hold this back? @GGabriele @Tieske ?

@Tieske Tieske requested a review from hbagdi October 12, 2023 19:20
@RobSerafini
Copy link

@Kong/team-deck - Would appreciate your review on this. It seems safe enough to me and we could always revert if there are problems.

@Tieske Tieske marked this pull request as ready for review October 18, 2023 07:35
@Tieske Tieske requested a review from a team October 18, 2023 07:35
@Tieske Tieske merged commit d30b35f into main Oct 18, 2023
@Tieske Tieske deleted the analytics branch October 18, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants