Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: sync/diff command - use of '-' indicates to read from stdin #8

Closed
matthewbednarski opened this issue Apr 5, 2019 · 2 comments
Closed

Feature Request: sync/diff command - use of '-' indicates to read from stdin #8

matthewbednarski opened this issue Apr 5, 2019 · 2 comments

Comments

@matthewbednarski
Copy link
Contributor

Hi,

It would be nice if the sync and diff commands would read try to read from stdin if a '-' (dash) is indicated on the command line.
@hbagdi
Copy link
Member

hbagdi commented Apr 7, 2019

Hi @matthewbednarski

This would certainly be a great addition, PR welcome!

@matthewbednarski
Copy link
Contributor Author

Hi @hbagdi,

I'm not a go programmer but I'll try to dedicate some time to it.

Btw, I love this program!

matthewbednarski added a commit to matthewbednarski/deck that referenced this issue Apr 9, 2019
@matthewbednarski
feature: resolves Kong#8; sync/diff support read from stdin
4980ed1
@matthewbednarski matthewbednarski mentioned this issue Apr 9, 2019
Closed
@hbagdi hbagdi closed this as completed in c08a684 Apr 13, 2019
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
feat: drop Validator Interface and methods
10ecfd0 
In the past, Validator interface was added to implement
client side validation of Kong entities.

Overtime, Kong entities have undergone a lot of change and become
much more complicated.
Replicating the schema check library in Go code
will complicate things, introduce more bugs and won't buy us much.
We have already been bitten by this solution:
#44

Hence, this is being dropped from the library.

In future, if this is needed, a better solution would be to either
re-use schema library of Kong here or at least re-use the schema of Kong
entities, that is exposed on the Admin API as of Kong 1.2.

From #8
rainest pushed a commit that referenced this issue Apr 21, 2021
@mflendrich
feat: rich HTTP errors (#8)
dc1e575 
* fix: use the public API to tell if err is 404

* feat: rich api error messages

* chore: delete type err404, add tests

* test(response): add test cases, rename test
rainest pushed a commit that referenced this issue Apr 21, 2021
@matthewbednarski
feat(file) read state from stdin when s -
9b1fcb5 
Using the `-s` flag, `-` is a special value now to read the input from
standard input rather than a file.

Fix #8
From #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: diff/sync commands - read from stdin - resolves #8 matthewbednarski/deck
2 participants
@matthewbednarski @hbagdi