Deck always defaults to konnect.yaml instead of kong.yaml

[cwurm]

With decK 1.5 the default Kong configuration file is konnect.yaml and no longer kong.yaml. Reading the code, I believe this is a mistake? The non-Konnect commands still have kong.yaml as the default, e.g.

deck/cmd/dump.go

Lines 152 to 154 in a640f10

	dumpCmd.Flags().StringVarP(&dumpCmdKongStateFile, "output-file", "o",
	"kong", "file to which to write Kong's configuration."+
	"Use '-' to write to stdout.")

However, the same variable names are used in the Konnect commands, e.g.

deck/cmd/konnect_dump.go

Lines 80 to 82 in a640f10

	konnectDumpCmd.Flags().StringVarP(&dumpCmdKongStateFile, "output-file", "o",
	"konnect", "file to which to write Kong's configuration."+
	"Use '-' to write to stdout.")

What I think is happening is that the first thing StringVarP does is set the variable to the default value in https://github.com/spf13/pflag/blob/85dd5c8bc61cfa382fecd072378089d4e856579d/string.go#L6-L9

And since the Konnect files are alphabetically after the non-Konnect files their default value will always overwrite the non-Konnect values during package initialization.

The different commands should probably just use different variables to avoid any crossover.

[rainest]

Particularly annoying for dump because of the way the --all-workspaces sanity check works. The value is konnect regardless of which command you're using, so it fails on 1.5:

$ ./deck14 dump --all-workspaces
$ ./deck15 dump --all-workspaces 
Error: output-file cannot be specified with --all-workspace flag

A temporary workaround for 1.5 is to explicitly specify the old default. Even though it's not used for the filenames, it allows the check to pass and continues on to create the workspace filenames normally:

$ ./deck15 dump --all-workspaces -o kong

[danielkocot]

I use deck a lot in CI/CD contexts.

• For validate it has to be kong.yaml
• diff needs a konnect.yaml
• And sync needs a kong.yaml again

It would nice to have the opportunity to flag the name of config file on demand. As a workaround I always use mv on bash.