Skip to content

Commit

Permalink
fix: do not error out on EE endpoints with no license
Browse files Browse the repository at this point in the history
Right now decK error out when the Consumer Groups and
Vaults list endpoints are hit and no license is present in the
Gateway.
In such case, decK should continue its flow.
  • Loading branch information
GGabriele committed Jan 24, 2023
1 parent 10ac89d commit c03e6ac
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Table of Contents

- [v1.17.2](#v1172)
- [v1.17.1](#v1171)
- [v1.17.0](#v1170)
- [v1.16.1](#v1161)
Expand Down Expand Up @@ -49,6 +50,16 @@
- [v0.2.0](#v020)
- [v0.1.0](#v010)

## [v1.17.2]

> Release date: 2023/01/13
### Fixes

- Do not error out when EE list endpoints are hit but no
license is present in Kong Gateway.
[#821](https://github.com/Kong/deck/pull/821)

## [v1.17.1]

> Release date: 2022/12/22
Expand Down Expand Up @@ -1113,6 +1124,7 @@ No breaking changes have been introduced in this release.

Debut release of decK

[v1.17.2]: https://github.com/kong/deck/compare/v1.17.1...v1.17.2
[v1.17.1]: https://github.com/kong/deck/compare/v1.17.0...v1.17.1
[v1.17.0]: https://github.com/kong/deck/compare/v1.16.1...v1.17.0
[v1.16.1]: https://github.com/kong/deck/compare/v1.16.0...v1.16.1
Expand Down
4 changes: 2 additions & 2 deletions dump/dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func getProxyConfiguration(ctx context.Context, group *errgroup.Group,
consumerGroups, err = GetAllConsumerGroups(ctx, client, config.SelectorTags)
}
if err != nil {
if kong.IsNotFoundErr(err) {
if kong.IsNotFoundErr(err) || kong.IsForbiddenErr(err) {
return nil
}
return fmt.Errorf("consumer_groups: %w", err)
Expand Down Expand Up @@ -622,7 +622,7 @@ func GetAllVaults(

for {
s, nextopt, err := client.Vaults.List(ctx, opt)
if kong.IsNotFoundErr(err) {
if kong.IsNotFoundErr(err) || kong.IsForbiddenErr(err) {
return vaults, nil
}
if err != nil {
Expand Down

0 comments on commit c03e6ac

Please sign in to comment.