-
Notifications
You must be signed in to change notification settings - Fork 129
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: diff with not-existing WS must not fail due to defaults
decK dynamically discovers entities defaults by interacting with the Kong Admin API. Queries to retrieve entities schema for a workspace that doesn't exist yet would fail though. When running `diff`, in order to prevent a failure, decK simply skips defaults injection for all entities, but it was still wrongly running queries for plugins, making the run fail. This PR makes sure plugins defaults injection is treated the same as other entities when running `diff` against a not-existing workspace.
- Loading branch information
Showing
2 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
tests/integration/testdata/diff/001-not-existing-workspace/kong.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
_workspace: test | ||
services: | ||
- name: svc1 | ||
host: mockbin.org | ||
host: mockbin.org | ||
plugins: | ||
- name: rate-limiting | ||
config: | ||
minute: 123 |