Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] update default worker count to 2 #227

Closed
2 tasks
hbagdi opened this issue Nov 12, 2020 · 2 comments
Closed
2 tasks

[kong] update default worker count to 2 #227

hbagdi opened this issue Nov 12, 2020 · 2 comments

Comments

@hbagdi
Copy link
Member

hbagdi commented Nov 12, 2020

The Helm chart sets nginx_worker_processes: "1". The original motivation for this default, against the kong default of auto was users seeing resource exhaustion when they installed Kong. This usually happened with k8s worker nodes containing a larger number of CPUs/vCPUs.
With the default of 1, we run into the other problem where a lot of users run into severe performance problems, especially with KIC DB-less deployments, where a sync (POST /config) request can introduce significant latencies on proxy requests.
Given the number of external and internal reports on this specific, we should update the default value to 2.

TODO:

  • Update the default value to 2 in this repository
  • Update the default value to 2 in Kong Ingress Controller's repository
@mflendrich
Copy link
Contributor

What is the resource consumption impact of this change?

@mflendrich
Copy link
Contributor

Suggest in update instructions that users override the new default with 1 if they encounter OOM after updating.

mflendrich pushed a commit to Kong/kubernetes-ingress-controller that referenced this issue Nov 16, 2020
**What this PR does / why we need it**:
KIC version of Kong/charts#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants