Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_token_info method #387

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Add get_token_info method #387

merged 4 commits into from
Nov 25, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Nov 19, 2024

Closes #385

  • added get_token_info doc and postman examples
  • added task::enable_eth::init, task::enable_eth::status, task::enable_eth::cancel examples to postman as they were missing. I've created an issue for adding docs for these in a separate PR.
  • Moved v2 Utility methods into their own subfolder. As the array of methods expands, it feels cleaner to group them into category subfolders. I'll continue to do this incrementally as part of future PRs.

@smk762 smk762 added KDF 2.2.0-beta awaiting review P1 Important task which needs to be completed soon labels Nov 19, 2024
Copy link

Preview for merge commit: e6a064b, available on cloudflare at: https://a8d988d0.komodo-docs.pages.dev/en/docs/

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be in order here. If I'm being nitpicky, I'd order the utility sidebar folder alphabetically, after overview. Though there are a few methods that are not in order in other categories, so this probably isn't very important, and not required for me to approve.

@smk762 smk762 merged commit aa4e6e7 into dev Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review KDF 2.2.0-beta P1 Important task which needs to be completed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants