Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix MTP retrieval in electrum mode for QTUM and ZER coins. #975

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Hotfix MTP retrieval in electrum mode for QTUM and ZER coins. #975

merged 2 commits into from
Jun 10, 2021

Conversation

artemii235
Copy link
Member

shamardy
shamardy approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sergeyboyko0791
sergeyboyko0791 suggested changes Jun 10, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing fixing the issue I started working on :D
I left just one question. If it's possible to avoid using CoinVariant, I would rather avoid it

mm2src/mm2_bitcoin/chain/src/block_header.rs Show resolved Hide resolved
mm2src/mm2_bitcoin/chain/src/block_header.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Jun 10, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm ready to approve this!

@artemii235 artemii235 merged commit 8bf6ed3 into mm2.1 Jun 10, 2021
@artemii235 artemii235 deleted the mm2.1-zer-qtum-locktime-fix branch June 10, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@shamardy shamardy shamardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemii235 @shamardy @sergeyboyko0791