Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing verbose transaction with large locktime #966 #970

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

sergeyboyko0791
Copy link

No description provided.

Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both ZER/KMD and QTUM/KMD swaps worked fine (buy and sell) without the parsing error showing up

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another problem because that big locktime was set by MM2 but it's not a blocker. I will hotfix it in a separate PR. @sergeyboyko0791 Thanks for the fast fix!

@artemii235 artemii235 merged commit 1512af8 into mm2.1 Jun 9, 2021
@artemii235 artemii235 deleted the fix-parsing-verbose-tx branch June 9, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid value: integer 2575874549, expected i32 on parsing txes
3 participants