Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the 'mm2_stop' FFI function #961 #962

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Add the 'mm2_stop' FFI function #961 #962

merged 3 commits into from
Jun 1, 2021

Conversation

sergeyboyko0791
Copy link

No description provided.

@sergeyboyko0791 sergeyboyko0791 changed the title Add the 'mm2_stop' FFI function Add the 'mm2_stop' FFI function #961 Jun 1, 2021
@sergeyboyko0791 sergeyboyko0791 self-assigned this Jun 1, 2021
@sergeyboyko0791 sergeyboyko0791 linked an issue Jun 1, 2021 that may be closed by this pull request
GUI need to be able to stop mm2 using FFI #961
Closed
@sergeyboyko0791
Copy link
Author

There is a case when the context is stopped, but electrum spawned futures are closing yet.
https://github.com/KomodoPlatform/AtomicDEX-mobile/issues/830

I think we should refactor mm2_status to return an actual status of spawned futures somehow.

artemii235
artemii235 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@artemii235 artemii235 merged commit a839d2f into dev Jun 1, 2021
@artemii235 artemii235 deleted the mm2-stop-ffi branch June 1, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

Assignees

@sergeyboyko0791 sergeyboyko0791

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI need to be able to stop mm2 using FFI
2 participants
@sergeyboyko0791 @artemii235