Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct direction of the pair for best_orders sell action. #863

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Use correct direction of the pair for best_orders sell action. #863

merged 1 commit into from
Mar 15, 2021

Conversation

artemii235
Copy link
Member

sergeyboyko0791
sergeyboyko0791 reviewed Mar 15, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have knowledge gaps, could you please answer my comment?

mm2src/lp_ordermatch/best_orders.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Mar 15, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it!

@artemii235 artemii235 merged commit f49226e into mm2.1 Mar 15, 2021
@artemii235 artemii235 deleted the mm2.1-best-orders-hotfix branch March 15, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemii235 @sergeyboyko0791