Fix MM2 compilation errors for wasm32 arch #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyboyko0791
commented
Mar 2, 2021
sergeyboyko0791
commented
- Remove "native" and "w-bindgen" features from toml files, replace the compilation conditions that depend on these features with target_arch = "wasm32"
- Remove feature = "native" from toml files, replace it with target_arch = "wasm32"
- Remove '--features native' from CI scripts
* Fix the 'unused_variable' warnings while using mm_metrics in wasm mode
* Add mm2_libp2p::runtime module * TODO pass a Js transport to the libp2p::wasm_ext::ExtTransport::new * TODO configure SwarmRuntime for wasm32 arch
* Replace feature = "native" with target_arch = "wasm32" in the remaining modules
* Replace feature = "w-bindgen" with target_arch = "wasm32"
* Replace eth::eth_tests::wasm_bindgen_tests into eth::eth_wasm_tests * Fix utxo_tests compilation errors on `cargo test --target wasm32-unknown-unknown --package coins`
* Add independent common::log::LogLevel enum * Add for_tests::require_log_level, use it in mm2_tests::test_best_orders # Conflicts: # mm2src/coins/Cargo.toml # mm2src/coins/eth/eth_tests.rs # mm2src/coins/utxo/rpc_clients.rs # mm2src/common/Cargo.toml # mm2src/common/build.rs # mm2src/common/common.rs # mm2src/common/for_tests.rs # mm2src/common/mm_metrics/native.rs # mm2src/lp_network.rs # mm2src/lp_ordermatch.rs # mm2src/mm2_tests.rs # mm2src/rpc.rs
sergeyboyko0791
commented
Mar 5, 2021
| @@ -3,27 +3,26 @@ | |||
| //! Sometimes we need to call downstream, from a dependency and into a dependent crate, | |||
| //! such as when calling `mm2::rpc::process_rpc_request` from `common::MarketMakerIt::rpc`. | |||
| //! Here we can use C-like headers and/or constructible slots for that. | |||
| //! | |||
| //! TODO refactor this. | |||
There was a problem hiding this comment.
This TODO refers to the following comment.
|
|
||
| /// Access to `rpc::process_rpc_request` defined downstream. | ||
| /// Initialized in `rpc::init_header_slots`. | ||
| #[cfg(not(feature = "native"))] | ||
|
|
||
| pub static RPC_SERVICE: Constructible< |
There was a problem hiding this comment.
I suggest refactoring the RPC_SERVICE somehow in the next iteration. It's just why I left the TODO above.
artemii235
suggested changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.