Add best_orders RPC #840
Merged
Add best_orders RPC #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm2src/lp_ordermatch.rs
Outdated
| None => return Ok(None), | ||
| }; | ||
| let mut result = HashMap::new(); | ||
| let pairs: Vec<_> = tickers.iter().map(|ticker| (coin.clone(), ticker.clone())).collect(); |
There was a problem hiding this comment.
I guess we could avoid collect().
I mean something like that:
let pairs = tickets.iter().map(|ticker| (coin.clone(), ticker.clone()));
for pair in pairsThere was a problem hiding this comment.
Good point, let me check it.
mm2src/lp_ordermatch.rs
Outdated
| }, | ||
| }; | ||
| } | ||
| result.insert(pair.1.clone(), best_orders); |
There was a problem hiding this comment.
Considering the previous comment, we could replace pair.1.clone() with pair.1
| fn orderbook_item_with_proof(&self, order: OrderbookItem) -> Result<OrderbookItemWithProof, ()> { | ||
| Ok(OrderbookItemWithProof { | ||
| order, | ||
| last_message_payload: vec![], |
There was a problem hiding this comment.
Are the default last_message_payload and proof just temporary?
There was a problem hiding this comment.
Yeah, I added these fields for future use to have a proper validation of the received data.
|
@sergeyboyko0791 Thanks for your review! Please recheck the code 🙂 |
sergeyboyko0791
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#805