Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max_taker_vol_from_available #824

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix max_taker_vol_from_available #824

merged 1 commit into from
Feb 18, 2021

Conversation

sergeyboyko0791
Copy link

  • max_taker_vol RPC handler will return 0 if calc_max_taker_vol returns an error
  • max_taker_vol_from_available return an error instead of 0

@sergeyboyko0791
Fix max_taker_vol_from_available
faa428b 
* max_taker_vol RPC handler will return 0 if calc_max_taker_vol returns an error
* max_taker_vol_from_available return an error instead of 0
artemii235
artemii235 reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question

mm2src/lp_swap/taker_swap.rs Show resolved Hide resolved
@artemii235 artemii235 merged commit 1be7cb5 into mm2.1 Feb 18, 2021
@artemii235 artemii235 deleted the fix-max-taker-vol branch February 18, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyboyko0791 @artemii235