Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version p2p request #1026

Merged
merged 8 commits into from
Aug 11, 2021
Merged

version p2p request #1026

merged 8 commits into from
Aug 11, 2021

Conversation

shamardy
Copy link
Collaborator

artemii235
artemii235 suggested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have few changes requests mostly related to the recently deprecated parts of code 🙂

mm2src/database/stats_nodes.rs Outdated Show resolved Hide resolved
mm2src/lp_network.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/rpc/dispatcher/dispatcher_legacy.rs Outdated Show resolved Hide resolved
mm2src/mm2_libp2p/src/atomicdex_behaviour.rs Outdated Show resolved Hide resolved
artemii235
artemii235 suggested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review iteration 2 🙂

mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/mm2_libp2p/src/atomicdex_behaviour.rs Outdated Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 suggested changes Aug 4, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Could you please consider the following changes?

mm2src/lp_network.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
mm2src/lp_stats.rs Outdated Show resolved Hide resolved
artemii235
artemii235 previously approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

sergeyboyko0791
sergeyboyko0791 approved these changes Aug 9, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Approve :)

@artemii235 artemii235 merged commit 7489372 into dev Aug 11, 2021
@artemii235 artemii235 deleted the version-p2p-request branch August 11, 2021 06:02
@shamardy shamardy mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@artemii235 artemii235 artemii235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamardy @artemii235 @sergeyboyko0791