Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH/ERC20 withdraw always return hardcoded ETH in fee_details. #860

Closed
artemii235 opened this issue Mar 12, 2021 · 2 comments
Closed

ETH/ERC20 withdraw always return hardcoded ETH in fee_details. #860

artemii235 opened this issue Mar 12, 2021 · 2 comments
Assignees
@artemii235

Comments

@artemii235
Copy link
Member

No description provided.

@artemii235 artemii235 added the bug label Mar 12, 2021
@artemii235 artemii235 self-assigned this Mar 12, 2021
@artemii235
Copy link
Member Author

artemii235 commented Mar 13, 2021 •
edited
Loading

This can actually be a part of #801. Checklist:

  • Get BNB on Binance smart chain testnet.
  • Deploy a BEP20(ERC20) token to BSC testnet.
  • Add the Binance smart chain BNB (BSCBNBT - T stands for testnet) and deployed BEP20 to coins config.
  • Fix the withdraw RPC for BSCBNBT and BEP20 so it displays BSCBNBT coin in fee_details.

Withdraw docs: https://developers.atomicdex.io/basic-docs/atomicdex/atomicdex-api.html#withdraw
ETH example in coins file: https://github.com/KomodoPlatform/coins/blob/master/coins#L622

@shamardy shamardy mentioned this issue Mar 13, 2021
Merged
artemii235 pushed a commit that referenced this issue Mar 22, 2021
@shamardy
fix hardcoded "ETH" in withdraw fee_details #860 (#861)
e14a556 
* fix hardcoded "ETH" in withdraw fee_details

* used platform key in coins for coin in fee_details

* platform field add to Erc20/remove hardcoded "ETH"

* Code Formatting

* Fix clippy warnings

Co-authored-by: Omar <omar.shamardy@sbs-me.com>
@artemii235
Copy link
Member Author

Hardcode is fixed, BNB/BEP20 integration is tracked in another issue, closing.

@yurii-khi yurii-khi mentioned this issue Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemii235 artemii235

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemii235