Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fields to orderbook response to make charts rendering in mobile GUI easier. #859

Closed
artemii235 opened this issue Mar 12, 2021 · 2 comments
Closed

Add more fields to orderbook response to make charts rendering in mobile GUI easier. #859

artemii235 opened this issue Mar 12, 2021 · 2 comments
Assignees
@artemii235

Comments

@artemii235
Copy link
Member

artemii235 commented Mar 12, 2021 •
edited
Loading

According to @yurii-khi, we have performance problems with many items in the orderbook because each orderbook item in the GUI list is actually stateful: to display "stairs" charts, e.g.:

GUIs have to calculate the aggregated volume at each order and divide it by total volume. Providing such info from MM2 will help them to make list items stateless and greatly improve performance on big lists.
@artemii235 artemii235 self-assigned this Mar 12, 2021
@artemii235 artemii235 mentioned this issue Mar 29, 2021
Merged
artemii235 added a commit that referenced this issue Mar 31, 2021
@artemii235
orderbook and trade_preimage RPC improvements #859 #872 (#883)
5c864f5 
* WIP.

* WIP.

* WIP.

* WIP and fix clippy.

* Refactor and fix clippy.

* WIP. Adding the UTXO fee to spend other payment to trade_preimage.

* WIP. Refactor tests.

* Finalize trade_preimage changes and refactor tests.

* Add paid_from_trading_vol to SavedTradeFee and refactor.

* Fix WASM tests compilation.

* Add separate TotalTradeFee struct for total_fees.

* Set QTUM/QRC20 mature_confirmations to 2000.
@artemii235
Copy link
Member Author

Done, docs are updated: https://developers.atomicdex.io/basic-docs/atomicdex/atomicdex-api.html#response-49
cc @yurii-khi

@yurii-khi
Copy link

Done, docs are updated: https://developers.atomicdex.io/basic-docs/atomicdex/atomicdex-api.html#response-49
cc @yurii-khi

Thanks for this feature, it should help to improve performance indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemii235 artemii235

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artemii235 @yurii-khi