-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering for not mine (STATS) swaps #799
Comments
@tonymorony Thanks for creating the issue! Could you please provide more details about the expected SQLite table data/schema? I guess we need the following columns: UUID, maker_coin, taker_coin, maker_amount, taker_amount, started_at (maybe separate for maker and taker too), but maybe something else is required? |
yeah, that looks like enough data. also separation between successful and failed would be helpful just rechecked data from the swap status structure we using:
The most tricky matter we got in our stats tool so far is to determine the list of pairs with >0 swaps - we should scan all possible permutations. Is it possible to create such an "alive pairs" list during import into DB? it'll help a lot |
Sure, just one question: should we add both |
counting logic using both ways now (according to dexstats.info not only we counting both ways) - so would be great to include it as RICK/MORTY + MORTY/RICK if there are both directions trades (if it's not a huge complication to list creation logic) |
@tonymorony I have implemented the indexing of swaps statistics to the SQLite DB. You can use the build from http://195.201.0.6/mm2.1-stats-swaps-index-filter/ until the corresponding PR is merged. The SQLite file path is
You can now get them using the |
Works like a charm, thank you! Parser (WIP) with this DB usage https://github.com/tonymorony/dexstats_sqlite_py |
It would be wonderful to use DB and filtration/pagination functionality not only for
my_orders
swap statuses but also for collected swap statuses on seed nodesref: #33
The text was updated successfully, but these errors were encountered: