Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdrawal to P2SH addresses for non-Segwit coins. #1278

Closed
artemii235 opened this issue May 3, 2022 · 7 comments
Closed

Withdrawal to P2SH addresses for non-Segwit coins. #1278

artemii235 opened this issue May 3, 2022 · 7 comments
Assignees
@cipig @smk762 @laruh

Comments

@artemii235
Copy link
Member

In rare use cases, users might need to withdraw to multisig or other P2SH addresses.
@artemii235 artemii235 mentioned this issue May 3, 2022
Open
@cipig
Copy link
Member

cipig commented May 20, 2022

the BCH deposit address on Nicehash is P2SH and shows error when trying to send BCH to it
setting segwit:true on BCH "fixes" the problem

@himu007
Copy link

himu007 commented May 26, 2022

I would like to request to enable withdraw KMD or any other ACs to b addresses. Today I tried to withdraw KMD to a multisig address and atomicDEX Mobile was showing Invalid Address.

Implementing this will make life easier for end users. Since, multisig addresses are valid address, I don't see any proper reason not to implement this.

@artemii235
Copy link
Member Author

@cipig @himu007 Thanks for your input on this! We will implement it in the coming month.

@laruh laruh mentioned this issue Jun 30, 2022
Merged
artemii235 pushed a commit that referenced this issue Jul 7, 2022
@laruh
Enable withdraw non-segwit coins to P2SH addresses #1278 (#1330)
ef9c318 
* conf.segwit removed from is_p2sh in utxo

* fmt fix

* is_p2sh = conf.segwit removed in qrc20.rs

* is_p2sh = conf.segwit returned in qrc20.rs

* withdrawal to address should fail

* QRC20 can be sent to P2PKH addresses only

* "segwit":true removed if no "bech32_hrp", doc comment changed

* segwit comment simplified
@artemii235
Copy link
Member Author

@cipig @himu007 It has been done, could you test the latest dev, please? cc @smk762

@cipig
Copy link
Member

cipig commented Nov 17, 2022

works fine
to test i have set segwit:false for LTC, but could do this withdraw to MWwPtcmY43HocmNhcXY7q5o18vvsrTNv5U:
https://chainz.cryptoid.info/ltc/tx.dws?fe7b7acdd21d9e24c3dde2c953a6d39541fa96519446fe2aa0ee00f0d9031a18.htm

@smk762
Copy link

smk762 commented Nov 21, 2022

Using same address as above in GUI was successful and explorer returns expected result
image
https://blockchair.com/litecoin/transaction/42cae665742f2a3480daf44496490e1a0ff750b236bf3f6c1b38e541504c32ea

@artemii235
Copy link
Member Author

Great, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cipig cipig

@smk762 smk762

@laruh laruh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@himu007 @artemii235 @cipig @smk762 @laruh