review(sami): let event getter return a reference to avoid copying

KomodoPlatform · Nov 18, 2024 · f5dbfdd · f5dbfdd
1 parent 5f775d6
commit f5dbfdd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/mm2src/mm2_event_stream/src/event.rs b/mm2src/mm2_event_stream/src/event.rs
@@ -40,8 +40,8 @@ impl Event {
     pub fn origin(&self) -> &str { &self.event_type }
 
     /// Returns the event type and message as a pair.
-    pub fn get(&self) -> (String, Json) {
+    pub fn get(&self) -> (String, &Json) {
         let prefix = if self.error { "ERROR:" } else { "" };
-        (format!("{prefix}{}", self.event_type), self.message.clone())
+        (format!("{prefix}{}", self.event_type), &self.message)
     }
 }
diff --git a/mm2src/mm2_event_stream/src/manager.rs b/mm2src/mm2_event_stream/src/manager.rs
@@ -464,7 +464,7 @@ mod tests {
             let event = client1.try_recv().unwrap();
             assert_eq!(event.origin(), streamer_id);
             // It's an echo streamer, so the message should be the same.
-            assert_eq!(event.get().1, json!(msg));
+            assert_eq!(event.get().1, &json!(msg));
         }
 
         // If we send the wrong datatype (void here instead of String), the streamer should ignore it.