Generate app coin configs #502

smk762 · 2022-10-05T19:06:20Z

Basic repo parsing is implemented, along with some updates to the coins repo to cover missing pieces so script doesn't fail.
More updates to coins repo are needed:

Create files for missing explorers \ electrums
Create files for coinparika, coingecko & nomics ids
Add fields required for webdex \ mobile which are not yet present.
Add output to highlight fields missing required values
Scan electrums to exclude non-functional from output
Add bchd_urls
Add lightwalletd_servers

yurii-khi · 2022-10-06T05:44:22Z

Thanks for PR opening, @smk762 !
Noticed, that generate_app_configs.py uses hardcoded explorer urls, while explorers directory supposedly contains required data. Is it possible to use urls from that directory instead?
PS: I do realize that urls in explorers folder might be outdated, I'm just thinking maybe it's a good timing for update.

smk762 · 2022-10-06T05:49:43Z

Thanks for PR opening, @smk762 ! Noticed, that generate_app_configs.py uses hardcoded explorer urls, while explorers directory supposedly contains required data. Is it possible to use urls from that directory instead? PS: I do realize that urls in explorers folder might be outdated, I'm just thinking maybe it's a good timing for update.

Yes that is the plan. The hardcoded urls server two purposes at the moment.
One is for the explorers for tokens - this can be added to a file like BNB in explorers folder, with tokens coded to use the parent chain's explorer.
The other case is a bit more of a challenge - it's for special cases where the tx or address link url path differs. This info is not in the coins repo, and the current format of the explorers files is a list - would need to convert to dict to include this (alternatively a new file explorer_suffixes could be created to define this rather than the script).

yurii-khi · 2022-10-06T05:56:38Z

Thanks for PR opening, @smk762 ! Noticed, that generate_app_configs.py uses hardcoded explorer urls, while explorers directory supposedly contains required data. Is it possible to use urls from that directory instead? PS: I do realize that urls in explorers folder might be outdated, I'm just thinking maybe it's a good timing for update.

Yes that is the plan. The hardcoded urls server two purposes at the moment. One is for the explorers for tokens - this can be added to a file like BNB in explorers folder, with tokens coded to use the parent chain's explorer. The other case is a bit more of a challenge - it's for special cases where the tx or address link url path differs. This info is not in the coins repo, and the current format of the explorers files is a list - would need to convert to dict to include this (alternatively a new file explorer_suffixes could be created to define this rather than the script).

Great, thanks for clarification!

smk762 · 2022-10-06T09:35:38Z

@artemii235 I'll be removing DEC8 (testcoin) - there has been no activity on this token for around 5 years, so I assume it is not being used in API tests. ref: https://etherscan.io/address/0x3ab100442484dc2414aa75b2952a0a6f03f8abfd

smk762 · 2022-10-06T12:15:04Z

@cipig The following list of coins has no nodes/electrums info either in this repo or in desktop:

AXO
AYA
BEER (dead? keep for the memories?)
BTCH (dead)
COLX
COQUI (dead)
FLASH
FLO
LUX
NIX
OOT(dead? keep for the memories?)
PEO
PIVX
PIZZA (dead? keep for the memories?)
PRCY (appears to be active, we have BEP20 etc variants listed)
RIC
RIC-segwit
SIRX
VIA
VIA-segwit
VTC
VTC-segwit
WLC
XSN
XVC-OLD **(restored)**
YCE
ZET-OLD **(removed)**
FLUX **(restored)**

Can you please help categorise them into remove from repo | set to "mm2": 0 | able to find electrum?

cipig · 2022-10-06T13:00:43Z

XVC-OLD has electrums:

    "electrum": [
      {
        "url": "electrumx.xvc.ewmcx.org:50001",
        "protocol": "TCP"
      },
      {
        "url": "failover.xvc.ewmcx.biz:50001",
        "protocol": "TCP"
      }
    ],

chain switch is taking place, XVC-OLD is wallet-only though, can't be traded... but i would keep it till chain switch is done
ZET-OLD can be removed, chain switch is done there
other coins like VTC, VIA are working, but have no electrums... question is: why remove them? simply keep them till we find electrums or till they pay us for running them
idk why PRCY doesn't have the UTXO variant enabled, i guess they were having trouble with the chain or with testing
AXO, BEER, BTCH, COQUI, OOT, PIZZA, WLC are old KMD smartchains and can be likely removed
please don't remove FLUX, it's being actively used:

    "electrum": [
      {
        "url": "electrumx.runonflux.io:50002",
        "protocol": "SSL",
        "disable_cert_verification": true,
        "ws_url": "electrumx.runonflux.io:50004"
      },
      {
        "url": "electrumx2.runonflux.io:50001",
        "protocol": "TCP",
        "ws_url": "electrumx2.runonflux.io:50004"
      }
    ],

smk762 · 2022-10-06T13:09:33Z

question is: why remove them?
I'd only want to remove known dead coins. Anything else that is lacking some info we can just set "mm2":0 so they are ignored by apps if they are missing the info needed to run on them.

cipig · 2022-10-06T13:24:57Z

AXO old smartchain, remove from repo
AYA idk, we notarize this coin, but no electrums... would actually like to add it
BEER old smartchain, remove from repo
BTCH old smartchain, remove from repo
COLX set to "mm2": 0
COQUI old smartchain, remove from repo
FLASH set to "mm2": 0
FLO set to "mm2": 0
LUX set to "mm2": 0
NIX set to "mm2": 0
OOT old smartchain, remove from repo
PEO set to "mm2": 0
PIVX set to "mm2": 0
PIZZA old smartchain, remove from repo
PRCY coin is active, but not the UTXO variant, idk why
RIC set to "mm2": 0
RIC-segwit set to "mm2": 0
SIRX set to "mm2": 0
VIA set to "mm2": 0
VIA-segwit set to "mm2": 0
VTC set to "mm2": 0
VTC-segwit set to "mm2": 0
WLC old smartchain, remove from repo
XSN set to "mm2": 0
XVC-OLD please keep till chain switch
YCE set to "mm2": 0
ZET-OLD can be removed, chain switch is done
FLUX please keep, works fine

smk762 · 2022-10-06T13:30:39Z

Thanks - on second thought the ones without electrums which are still kicking could be used in native mode, so I"ll leave them as "mm2":1.
Agree about AYA, I asked them a while ago.

smk762 · 2022-10-13T14:46:51Z

cc: @ologunB ready for review

electrums/XVC

electrums/ZET

ologunB · 2022-10-13T19:02:53Z

Just a note. These coins have their coingecko_id empty in json. coingecko_id is only used as a fallback to get some prices on mobile. So not 'too pressing'.

["ADEXBSCT","ADEXBSC","ANKR-PLG20","APE-FTM20","APE-PLG20","ATOM-PLG20","AYA","BRZ-PLG20","BRZ-AVX20","BTCZ-BEP20","DDD","DENT","GETH","GLM-ERC20","GLM-PLG20","GM-BEP20","GMX-AVX20","KNC-PLG20","KNC-AVX20","LDO-ERC20","LDO-PLG20","MOVI","NINJA","NPXS","SHIB-KRC20","RFOX","SMTF-OLD","SOL-PLG20","SOLVE","SWAP-BEP20","tBTC","WOO-ERC20","WOO-AVX20","WOO-BEP20","WOO-FTM20","WOO-PLG20","YFI-PLG20","FENIX","BOT","AWR","MED","PLY","ENT","CFUN","EPC","ZAT","WID","SEELE","JWL","BTRS","BRC","EUM"]

Also, these coins have their coingecko_id to be test-coin but their is_testnet is false. So are they really test coins?

["ILNF-PLG20","ILNF-BEP20","ADEXBSCT","HONK","ASLP","BET","BOTS","CASE","CCL","CDN","CHTA","CHIPS","CLC","CRYPTO","DEX","EILN-ERC20","FJCB","HODL","IL8P","ILN","ILN-BEP20","ILN-PLG20","ILNSW-PLG20","JUMBLR","LABS","MCL","MESH","MGW","MSHARK","NENG","NYAN","PANGEA","SFUSD","PRUX","QIAIR","REVS","SOULJA","SPACE","SUPERNET","SCA","TAMA-ERC20","tBTC","VRM","WSB","XRG","ZILLA","USBL","SIBM-BEP20","ZOMBIE"]

edit by smk: sorry, meant to quote and clicked the wrong button. Restored to original.

smk762 · 2022-10-14T10:40:13Z

Just a note. These coins have their coingecko_id empty in json. coingecko_id is only used as a fallback to get some prices on mobile. So not 'too pressing'.
...
Also, these coins have their coingecko_id to be test-coin but their is_testnet is false. So are they really test coins?
...

I'll go thru the list an see what I can find ids for. Not all without IDs are testcoins though, they might just not be registered with any of the price providers. Maybe for these instead of test-coin we can tag them as no-id to indicate they have been checked - though this will possibly mean some changes to code in apps using this data.

cipig · 2022-10-14T13:45:23Z

Just a note. These coins have their coingecko_id empty in json. coingecko_id is only used as a fallback to get some prices on mobile. So not 'too pressing'.

["ADEXBSCT","ADEXBSC","ANKR-PLG20","APE-FTM20","APE-PLG20","ATOM-PLG20","AYA","BRZ-PLG20","BRZ-AVX20","BTCZ-BEP20","DDD","DENT","GETH","GLM-ERC20","GLM-PLG20","GM-BEP20","GMX-AVX20","KNC-PLG20","KNC-AVX20","LDO-ERC20","LDO-PLG20","MOVI","NINJA","NPXS","SHIB-KRC20","RFOX","SMTF-OLD","SOL-PLG20","SOLVE","SWAP-BEP20","tBTC","WOO-ERC20","WOO-AVX20","WOO-BEP20","WOO-FTM20","WOO-PLG20","YFI-PLG20","FENIX","BOT","AWR","MED","PLY","ENT","CFUN","EPC","ZAT","WID","SEELE","JWL","BTRS","BRC","EUM"]

This are all coins present in coins file of coins repo, but not in ADEX Desktop... some are from the unmerged PR KomodoPlatform/komodo-wallet#1997

the coins from second list are not listed on coingecko, so also no id

SirSevenG

lgtm

yurii-khi

Lgtm, thank you @smk762 !

smk762 and others added 12 commits September 30, 2022 14:55

align with desktop

3978c9e

rm spare comma

aa6679e

rm dead electrums

77a0cc8

rm dead electrums

2709ff7

rm dead electrums

ade0b06

rm dead electrums

ce2594b

rm LUNA and UST

a3e3b4a

restore ABY electrums

d3b2acb

rm CHUNG

62015c2

rm old xvc

a49cb13

Update ZET

a924df9

init script

74cdb2c

smk762 marked this pull request as draft October 5, 2022 19:06

smk762 added 4 commits October 6, 2022 03:53

fix logic for ETH-like

da7a8ed

add name

e11a8a1

add explorers for tokens

5a7864b

add explorers for segwit tickers

12bd892

add explorers, handle token explorers

06e05c2

fix explorers with suffixes

44d6f25

add FLUX / XVC-OLD electrums

abd9aea

pour one out for our fallen smartchains

6dc9097

smk762 and others added 6 commits October 12, 2022 22:23

add suffix for bep20 token adress urls

e2ede8e

add suffix for bep20 token adress urls

c9a05e6

Update coin configs

a5afe00

merge in master

543b0e3

ads http

576c571

Update coin configs

4ea9b3c

smk762 requested review from cipig, SirSevenG and yurii-khi October 13, 2022 14:44

smk762 marked this pull request as ready for review October 13, 2022 14:45

smk762 added 2 commits October 13, 2022 22:48

change CI trigger branch to master

339a948

update CI trigger branch

6c81a83

cipig reviewed Oct 13, 2022

View reviewed changes

electrums/XVC Outdated Show resolved Hide resolved

cipig reviewed Oct 13, 2022

View reviewed changes

electrums/XVC Outdated Show resolved Hide resolved

cipig reviewed Oct 13, 2022

View reviewed changes

electrums/ZET Outdated Show resolved Hide resolved

smk762 added 3 commits October 14, 2022 03:40

better scan report structure

da379a9

review fix electrums

f9d975f

new output format

4e45758

smk762 added 2 commits October 14, 2022 22:37

add some IDs, sort keys

9247e93

add some ids

4d01dfe

SirSevenG approved these changes Oct 17, 2022

View reviewed changes

SirSevenG requested a review from tonymorony October 20, 2022 11:18

yurii-khi approved these changes Oct 20, 2022

View reviewed changes

tonymorony approved these changes Oct 20, 2022

View reviewed changes

tonymorony merged commit 3ebd32f into master Oct 20, 2022

cipig deleted the parse_repo branch June 27, 2023 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate app coin configs #502

Generate app coin configs #502

smk762 commented Oct 5, 2022 •

edited

Loading

yurii-khi commented Oct 6, 2022

smk762 commented Oct 6, 2022

yurii-khi commented Oct 6, 2022

smk762 commented Oct 6, 2022

smk762 commented Oct 6, 2022 •

edited

Loading

cipig commented Oct 6, 2022 •

edited

Loading

smk762 commented Oct 6, 2022

cipig commented Oct 6, 2022

smk762 commented Oct 6, 2022

smk762 commented Oct 13, 2022

ologunB commented Oct 13, 2022 •

edited by smk762

Loading

smk762 commented Oct 14, 2022 •

edited

Loading

cipig commented Oct 14, 2022

SirSevenG left a comment

yurii-khi left a comment

Generate app coin configs #502

Generate app coin configs #502

Conversation

smk762 commented Oct 5, 2022 • edited Loading

yurii-khi commented Oct 6, 2022

smk762 commented Oct 6, 2022

yurii-khi commented Oct 6, 2022

smk762 commented Oct 6, 2022

smk762 commented Oct 6, 2022 • edited Loading

cipig commented Oct 6, 2022 • edited Loading

smk762 commented Oct 6, 2022

cipig commented Oct 6, 2022

smk762 commented Oct 6, 2022

smk762 commented Oct 13, 2022

ologunB commented Oct 13, 2022 • edited by smk762 Loading

smk762 commented Oct 14, 2022 • edited Loading

cipig commented Oct 14, 2022

SirSevenG left a comment

Choose a reason for hiding this comment

yurii-khi left a comment

Choose a reason for hiding this comment

smk762 commented Oct 5, 2022 •

edited

Loading

smk762 commented Oct 6, 2022 •

edited

Loading

cipig commented Oct 6, 2022 •

edited

Loading

ologunB commented Oct 13, 2022 •

edited by smk762

Loading

smk762 commented Oct 14, 2022 •

edited

Loading