Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the other two ratings provided by OMDB #2422

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

chazlarson
Copy link
Contributor

Description

OMDB also provides Metascore and RT ratings in the API response. This adds support for them to the mass ratings updates.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

Please delete options that are not relevant.

  • Updated Documentation to reflect changes
  • Updated the CHANGELOG with the changes

@chazlarson chazlarson requested a review from YozoraXCII January 6, 2025 19:13
@YozoraXCII YozoraXCII added the docker Build Pull Request in Docker label Jan 6, 2025
@YozoraXCII
Copy link
Contributor

I've tested both omdb_metascore and omdb_tomatoes and can confirm both work as expected.

Happy for this to be merged.

@chazlarson chazlarson merged commit 9189148 into nightly Jan 6, 2025
4 checks passed
@chazlarson chazlarson deleted the expand-omdb-ratings branch January 6, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Build Pull Request in Docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants