-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial layout for matrices #111
Open
adamslc
wants to merge
10
commits into
Kolaru:master
Choose a base branch
from
adamslc:matrix_layout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
===========================================
- Coverage 81.02% 70.96% -10.07%
===========================================
Files 10 10
Lines 585 675 +90
===========================================
+ Hits 474 479 +5
- Misses 111 196 +85
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work in #56 (which itself builds on #50). All those commits
have been rebased onto master for convience.
I implemented a simple layout algorithm for matrices (only supports
matrix
right now, but extending to include
pmatrix
andbmatrix
should be possible).It works quite well for simple entries, although perhaps the entries should be
centered horizontally and vertically.
test.pdf
However, you can see that the layout is very poor when taller notation (e.g.
fractions) are used. I think this results from a misunderstanding on my part of
how they layout is done. In the second attached pdf, you can see pairs of
horizontal lines where I think the symbols should be, which disagrees quite
dramatically with where they are.
test_vert_extent.pdf