Add support for heapless feature to avoid alloc in no_std case #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkBst
reviewed
Dec 31, 2024
tests/version-number.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![allow(non_fmt_panic)] | |||
| #![allow(non_fmt_panics)] | |||
There was a problem hiding this comment.
if the old version was a miss-spelling and thus presumably inactive, then do we need this?
There was a problem hiding this comment.
Good question.
Seems to not be related to heapless/no_alloc, but since I modifyed it (should be to make the linter happy) I can remove it...
There was a problem hiding this comment.
was fixed and merged in #58 , so I will remove it while rebasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.