Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind code optimization/formatting #23110

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Bind code optimization/formatting #23110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf48afd
Bind code optimization/formatting
Nerivec Jun 20, 2024
f9f0842
Feedback
Nerivec Jun 22, 2024
a06491b
Fix coverage
Nerivec Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/extension/availability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import debounce from 'debounce';
import bind from 'bind-decorator';
import * as zhc from 'zigbee-herdsman-converters';

const retrieveOnReconnect = [
const RETRIEVE_ON_RECONNECT: readonly {keys: string[], condition?: (state: KeyValue) => boolean}[] = [
{keys: ['state']},
{keys: ['brightness'], condition: (state: KeyValue): boolean => state.state === 'ON'},
{keys: ['color', 'color_temp'], condition: (state: KeyValue): boolean => state.state === 'ON'},
Expand Down Expand Up @@ -217,7 +217,7 @@ export default class Availability extends Extension {
logger.debug(`Retrieving state of '${device.name}' after reconnect`);

// Color and color temperature converters do both, only needs to be called once.
for (const item of retrieveOnReconnect) {
for (const item of RETRIEVE_ON_RECONNECT) {
if (item.condition && this.state.get(device) && !item.condition(this.state.get(device))) {
continue;
}
Expand Down
Loading