Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect device support for Innr RB 178 T #23911

Closed
magicus opened this issue Sep 8, 2024 · 2 comments
Closed

Incorrect device support for Innr RB 178 T #23911

magicus opened this issue Sep 8, 2024 · 2 comments
Labels
problem Something isn't working

Comments

@magicus
Copy link
Contributor

magicus commented Sep 8, 2024

What happened?

My new Innr RB 178 T is detected by Z2M, but the device description is wrong, so it looks like I could control the RGB color of the lamp. In fact, I can only change the color temperature of white light.

This is the external description from Z2M.

const {deviceEndpoints, light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['RB 178 T'],
    model: 'RB 178 T',
    vendor: 'innr',
    description: 'Automatically generated definition',
    extend: [deviceEndpoints({"endpoints":{"1":1,"2":2}}), light({"colorTemp":{"range":[200,454]}})],
    meta: {"multiEndpoint":true},
};

module.exports = definition;

While I can't say I fully understand this, my guess is that line 345 in innr.js should read:

  extend: [light({colorTemp: {range: [153, 555]}, turnsOffAtBrightness1: true})],

instead of (as now)

  extend: [light({colorTemp: {range: [153, 555]}, color: {applyRedFix: true}, turnsOffAtBrightness1: true})],

What did you expect to happen?

No RGB controls showing, since they are not supported by the light.

How to reproduce it (minimal and precise)

Connect a, Innr RB 178 T to Z2M. Notice that RGB controls show up. Verify that they do not change the light's color.

Zigbee2MQTT version

1.40.1

Adapter firmware version

0x26580700

Adapter

ConBee II

Setup

Hass OS add-on

Debug log

No response

@magicus magicus added the problem Something isn't working label Sep 8, 2024
@Koenkk
Copy link
Owner

Koenkk commented Sep 9, 2024

Fixed!

Changes will be available in the dev branch in a few hours from now.

@Koenkk Koenkk closed this as completed Sep 9, 2024
Koenkk added a commit to Koenkk/zigbee-herdsman-converters that referenced this issue Sep 9, 2024
@magicus
Copy link
Contributor Author

magicus commented Sep 9, 2024

Nice, thank you for the quick fix! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants