Move ESLint config and plugins to devDependencies #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-oakes
changed the title
Koenkk
reviewed
Jul 24, 2024
Koenkk
reviewed
Jul 24, 2024
matt-oakes
force-pushed
the
fix/dev-dependencies
branch
from
9419642 to
998da69
Compare
|
Thanks for the review. I've made those changes now. |
|
Thank you too! |
|
Great, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Thanks for all your work on Herdsman!
This PR moves the ESLint plugin and config dependencies into
devDependencies. This ensures they are no included by other packages which depend onzigbee-herdsman, reducing the overall bundle size, and ensuring there are no clashes with versions of packages used by other projects.