Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button events for QBKG03LM: hold, release. Cube event sides and angels #9

Merged
merged 4 commits into from
Jun 4, 2018
Merged

Button events for QBKG03LM: hold, release. Cube event sides and angels #9

merged 4 commits into from
Jun 4, 2018

Conversation

kirovilya
Copy link
Contributor

and I suggest renaming ep items "l1" and "l2" to "left" and "right" as buttons:

ep: {'l1': 2, 'l2': 3},
buttonsEp: {'left': 4, 'right': 5},

???

@kirovilya kirovilya changed the title Button events for QBKG03LM: hold, release Button events for QBKG03LM: hold, release. Cube event sides and angels Jun 3, 2018
else if (value === 3) action = {'action': 'fall'};
else if (value >= 512) action = {'action': 'tap', 'side': value-512};
else if (value >= 256) action = {'action': 'slide', 'side': value-256};
else if (value >= 128) action = {'action': 'flip180', 'side': value-128};
Copy link
Owner

@Koenkk Koenkk Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly side is a number, what does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is number. Sides numered as picture (from file):

                +---+
                | 2 |
            +---+---+---+
            | 4 | 0 | 1 |
            +---+---+---+
                |M5I|
                +---+
                | 3 |
                +---+

Copy link
Contributor Author

@kirovilya kirovilya Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mean side on top of cube on perform action

@Koenkk Koenkk merged commit c524fd1 into Koenkk:master Jun 4, 2018
@kirovilya
Copy link
Contributor Author

Thank you

xmow49 pushed a commit to xmow49/zigbee-herdsman-converters that referenced this pull request Jun 14, 2024
* start on znp refactor.

* More updates.

* More refactors.

* Zigbee2mqtt boots! :)

* Refactor types.

* Remove check option property.

* Add parsers for all types.

* Refactors.

* Add tests.

* Add tests and fix some parsers.

* Add znp tests

* complete tests

* Fix intialization

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants