Update devices/tuya.ts #8383
Merged
Update devices/tuya.ts #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New equipment GX04
Update tuya.ts
Add a new device GX04
Update tuya.ts
Koenkk
reviewed
Nov 27, 2024
src/devices/tuya.ts
Outdated
| @@ -13124,6 +13124,25 @@ const definitions: DefinitionWithExtend[] = [ | |||
| ], | |||
| }, | |||
| }, | |||
| { | |||
| fingerprint: tuya.fingerprint('TS0601', ['_TZE284_nhgdf6qr']), | |||
There was a problem hiding this comment.
Since the definition is the same, could you add this to the TS0601_soil definition and use tuya.whitelabel for correct detections (search in this file for some examples)
|
Hello. I noticed that they indeed have the same definition. However, the brand and model are different, and the product appearance also varies. I was wondering if it could be treated as a new product? Or is there another way to map TZE284_nhgdf6qr to the correct image, brand, and model?
| |
GIEX-CINLIN-RAUL
|
|
***@***.***
|
---- Replied Message ----
| From | Koen ***@***.***> |
| Date | 11/27/2024 15:14 |
| To | ***@***.***> |
| Cc | ***@***.***> ,
***@***.***> |
| Subject | Re: [Koenkk/zigbee-herdsman-converters] Update devices/tuya.ts (PR #8383) |
@Koenkk commented on this pull request.
In src/devices/tuya.ts:
@@ -13124,6 +13124,25 @@ const definitions: DefinitionWithExtend[] = [
],
},
},
+ {
+ fingerprint: tuya.fingerprint('TS0601', ['_TZE284_nhgdf6qr']),
Since the definition is the same, could you add this to the TS0601_soil definition and use tuya.whitelabel for correct detections (search in this file for some examples)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This exactly the usecase for |
|
Okay, I understand. I will modify it. |
|
Hello, I have added the code for the new device GX04 at line 2158 according to your guidance, and I have also added the new device GX03 at the end. Please review it. |
Koenkk
reviewed
Dec 2, 2024
| @@ -2155,6 +2155,7 @@ const definitions: DefinitionWithExtend[] = [ | |||
| [15, 'battery', tuya.valueConverter.raw], | |||
| ], | |||
| }, | |||
| whiteLabel: [tuya.whitelabel('GIEX', 'GX04', 'Soil Moisture Sensor', ['_TZE284_nhgdf6qr'])], | |||
There was a problem hiding this comment.
Also update fingerprint: tuya.fingerprint('TS0601', ['_TZE284_aao3yzhs']),
Koenkk
reviewed
Dec 2, 2024
Koenkk
reviewed
Dec 2, 2024
Koenkk
reviewed
Dec 2, 2024
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
|
Thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new device GX04