Add noise state for Livolo TI0001-illuminance #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jul 3, 2024
src/devices/livolo.ts
Outdated
| exposes: [ | ||
| e.noise_detected(), | ||
| e.illuminance().withUnit('%').withValueMin(0).withValueMax(100), | ||
| new Enum('noise_state', access.STATE, ['silent', 'normal', 'lively', 'noisy']).withDescription('Detected noise level'), |
There was a problem hiding this comment.
Suggested change
| new Enum('noise_state', access.STATE, ['silent', 'normal', 'lively', 'noisy']).withDescription('Detected noise level'), | |
| e.enum('noise_level', access.STATE, ['silent', 'normal', 'lively', 'noisy']).withDescription('Detected noise level'), |
noise_level looks better I guess, also update the fromZigbee converter.
There was a problem hiding this comment.
Agreed. Fixed now
PaulVanSchayck
force-pushed
the
livolo-illu2
branch
from
e566826 to
38529e0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already mentioned in PR #7707 , I was looking for a way to represent both the 4 different noise states the device reports, as well as a binary sensor when noise was detected.
Would this be an acceptable way? This works quite nicely for me.