-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _TZE204_rzrrjkz2 Smart Sprinkler Timer #7630
Conversation
add _TZE204_rzrrjkz2 Smart Sprinkler Timer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove some exposes
src/devices/tuya.ts
Outdated
onEvent: tuya.onEventSetTime, | ||
configure: tuya.configureMagicPacket, | ||
exposes: [ | ||
e.switch(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing a lot of exposes here, could you add them? Every datapoint in tuyaDatapoints
should have a corresponding expose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Koenkk,
Thank you for the fast respond, really appreciated,
I must say that I'm really new to GitHub and actually have a little knowledge on how to make exposes works.
The data point IDs are extracted from the device in Tuya Cloud Project, as I'm following from this instruction
https://www.zigbee2mqtt.io/advanced/support-new-devices/02_support_new_tuya_devices.html#_3-understanding-tuya-datapoints
I tried to put a lot of exposes before but it seems to be rejected, that's why I have to remove them.
Could you please provide me any instructions on how to make exposes works?
I can see these information on Device Debugging on Tuya Cloud Project, Not sure if it should help us on developing exposes?
Code | Type | Values -- | -- | -- switch | Boolean | "{true,false}" status | Enum | { "range": [ "off", "auto", "disabled" ] } countdown | Integer | { "unit": "min", "min": 1, "max": 240, "scale": 0, "step": 1 } countdown_left | Integer | { "unit": "min", "min": 1, "max": 240, "scale": 0, "step": 1 } water_current | Integer | { "unit": "gal/min", "min": 0, "max": 1000000000, "scale": 3, "step": 1 } battery_percentage | Integer | { "unit": "%", "min": 0, "max": 100, "scale": 0, "step": 1 } water_total | Integer | { "unit": "gal", "min": 0, "max": 999999999, "scale": 3, "step": 1 } weather_delay | Enum | { "range": [ "24h", "48h", "72h", "cancel" ] } normal_timer | String | { "maxlen": 255 } weather_switch | Boolean | "{true,false}" switch_enabled | Boolean | "{true,false}"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to put a lot of exposes before but it seems to be rejected, that's why I have to remove them.
What do you mean with "rejected" here?
For examples, please look at e.g. this:
expose
zigbee-herdsman-converters/src/devices/tuya.ts
Line 1104 in 4812c1b
e.numeric('max_temperature_alarm', ea.STATE_SET).withUnit('°C').withValueMin(-20).withValueMax(60) |
datapoint:
zigbee-herdsman-converters/src/devices/tuya.ts
Line 1127 in 4812c1b
[10, 'max_temperature_alarm', tuya.valueConverter.divideBy10], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Koenkk,
Thank you again for your contributing, your ZB2MQTT is absolute gold!
I tried to put a lot of exposes before but it seems to be rejected, that's why I have to remove them.
What do you mean with "rejected" here?
In the first version here (I'm still super new to GH not sure how to exact quote the version like you did)
2ef84ed
and it just not pass, then I just tried to remove them, but it's not the big deal, now I understand the concept from what you provided.
Will try to upload the new version.
Best regards
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
src/devices/tuya.ts
Outdated
@@ -8734,6 +8734,66 @@ const definitions: Definition[] = [ | |||
], | |||
}, | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this definition to neo.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to create a new pull request for this?
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
some how it shows
in this version 2d59044 and I'm not sure, what I do wrong? |
Wait, I think I figured out :) |
Thanks! Could you also submit a picture for the docs? This can be done by clicking here. Make sure that:
|
add _TZE204_rzrrjkz2 Smart Sprinkler Timer