Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develco AQSZB-110 should use μg/m3 for voc #5547

Merged
merged 5 commits into from
Mar 4, 2023
Merged

Develco AQSZB-110 should use μg/m3 for voc #5547

merged 5 commits into from
Mar 4, 2023

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Mar 4, 2023

  • changed the expose.voc() default to use μg/m3 (now inline with things like pm10, pm25, ...)
  • updated Develco AQSZB-110 to output μg/m3 for voc, fixing Unit of measurement for VOC seems to be wrong with current Home Assistant zigbee2mqtt#16057 for this device
  • Heiman HS2AQ-EM already seems to output μg/m3 from what I could find, should now also be fixed.
  • LifeControl and Aqara devices using the expose now have withUnit('ppb') added as they all seem to return ppb values and I couldn't easily located a formulate to convert that to μg/m3.

sjorge and others added 5 commits March 4, 2023 15:49
@sjorge
exposes: switch default unit for voc to µg/m3
f85ca0a 
This should partially adress Koenkk/zigbee2mqtt#16057

The following manufacturer have devices using this expose:
- heiman -> seems to actually report µg/m3 based on the photos of the display
- develco -> outputs ppb but formulate to convert it to µg/m3 is available (next commit)
- lifecontrol -> returns ppb, no formulate available will add withUnit('ppb')
- aqara (xiaomi) -< returns ppb, no formulate available will add withUnit('ppb')
@sjorge
Aqara VOCKQJK11LM uses ppb for voc
14e387a 
According https://dresden-elektronik.github.io/deconz-rest-doc/devices/xiaomi/xiaomi_airmonitor_acn01/ it does indeed output ppb.
 I've added withUnit('ppb') to the device's exposes data.
@sjorge
LifeControl MCLH-08 uses ppb for voc
854c512 
No much info available, adding withUnit('ppb') because that is what it was using before.
@sjorge
Develco AQSZB-110 switch voc to µg/m3
1cc2b85 
Newer doc revisions for the sensor (Sensirion SGP30) contains the formulate on how to convert ppb -> µg/m3
This should fix Koenkk/zigbee2mqtt#16057 for this device.
@Koenkk
Merge branch 'master' into devleco_voc
b991818
@Koenkk Koenkk merged commit bdc3895 into Koenkk:master Mar 4, 2023
@Koenkk
Copy link
Owner

Koenkk commented Mar 4, 2023

Enorm bedankt weer! 😄

@sjorge
Copy link
Contributor Author

sjorge commented Mar 4, 2023

Do note that for the LifeControl and Aqara devices Koenkk/zigbee2mqtt#16057 will still be an issue. Perhaps we should only let z2m create the hass component if the unit type is μg/m3?

@sjorge sjorge deleted the devleco_voc branch March 4, 2023 16:00
@Koenkk
Copy link
Owner

Koenkk commented Mar 5, 2023

@sjorge done!

@RobLeighton67
Copy link

RobLeighton67 commented Dec 13, 2023 •
edited
Loading

@sjorge been working recently with both the Develco AQSZB-110 and the Heiman HS2AQ-EM.
Just to clarify, the HS2AQ reports HCHO in mg/m3.
Even then the HS2AQ display shows for example 0.01 mg/m3 HCHO but Z2M publishes as HCHO : 0.1
All very confusing!

@sjorge
Copy link
Contributor Author

sjorge commented Dec 13, 2023

The HS2AQ probably needs a /100 on the value then.

@sjorge sjorge mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjorge @Koenkk @RobLeighton67