fix(lumi): pet feeder LED indicator control #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating to firmware version 9761, LED control doesn't work at all. Zigbee2mqtt reports "OFF" state, while indicator is turned on. Controlling the LED state either via zigbee2mqtt or via Home Assistant doesn't result in any change. I can only assume that previous firmware version (9505) got incorrect status mapping, while latest (9761) fixed this.
|
This is how LED control behaves in Home Assistant: |
|
LGTM! Let me know if it can be merged. |
|
@Koenkk sorry for bothering, tried this fix with external converter and it doesn't work - LED stays "on" no matter what. |
impankratov
deleted the
bugfix/aqara-pet-feeder-led-indicator-control
branch
Based on settings from Aqara app.
|
Ready for merge? |
|
@Koenkk Yep! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a revert of 3a5c6ae
After updating device to firmware version 9761, LED control doesn't work at all. Zigbee2mqtt reports "OFF" state, while indicator is turned on. Controlling the LED state either via zigbee2mqtt or via Home Assistant doesn't result in any change.
I can only assume that previous firmware version (9505) got incorrect status mapping, while latest (9761) fixed this.
Update:
Did some research and turns out, device logic is not so simple:
led_indicatorcontrols LED indicator night mode (with hard-coded time period). Added some description for this property.Tested via external converters, works great!
refs: