Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning for misconfiguration. #509

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Add a warning for misconfiguration. #509

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
851cd97
Add a warning for misconfiguration.
icfly2 Feb 16, 2021
001bec8
fixed missing bracket
icfly2 Feb 16, 2021
c5660ed
Update conf.py
icfly2 Feb 17, 2021
0f83856
Update conf.py
icfly2 Feb 17, 2021
fea33fe
Fixing typo
Koed00 Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions django_q/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from copy import deepcopy
from multiprocessing import cpu_count
from signal import signal
from warnings import warn

import pkg_resources
from django.conf import settings
Expand Down Expand Up @@ -130,6 +131,13 @@ class Conf:
# Only works with brokers that guarantee delivery. Defaults to 60 seconds.
RETRY = conf.get("retry", 60)

# Verify if retry and timeout settings are correct
if not TIMEOUT or (TIMEOUT > RETRY):
warn("""Retry and timeout are misconfigured. Set retry larger than timeout,
failure to do so will cause the tasks to be retriggered before completion.
See https://django-q.readthedocs.io/en/latest/configure.html#retry for details.""")


# Sets the amount of tasks the cluster will try to pop off the broker.
# If it supports bulk gets.
BULK = conf.get("bulk", 1)
Expand Down Expand Up @@ -189,8 +197,7 @@ class Conf:

# to manage workarounds during testing
TESTING = conf.get("testing", False)



# logger
logger = logging.getLogger("django-q")

Expand Down