[WIP]Change Django documentation links and URLs to a supported version (v1.8 -> v2.2) #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs were linking to a now unsupported version of Django. Django v2.2 is a LTS version, and also matches the documentation intersphinx_mapping in docs/conf.py.
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=========================================
Coverage ? 91.18%
=========================================
Files ? 47
Lines ? 3051
Branches ? 0
=========================================
Hits ? 2782
Misses ? 269
Partials ? 0
Continue to review full report at Codecov.
|
|
This is a tiny patch, but it's my first django-q commit and I can't see a contribution guide. I'm happy to do whatever legwork is required if someone can point me to it. |
|
Nice work. I never noticed this. I think the LTS is a good version to point at. |
Koed00
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull updates our documentation and code comments that link to the offical Django documentation to v2.2LTS. Currently they link to version 1.8 which is not supported by django-q, and is no longer supported by the Django team.
Users who follow the existing links will see a warning banner "This document is for an insecure version of Django that is no longer supported. Please upgrade to a newer release!".
NOTE: I wasn't sure which version to update them to I chose 2.2 because it's already used in the intersphinx_mapping in docs/conf.py. Alternatively we could update both to v3.1.
NOTE: I have not altered the CHANGELOG as I didn't want to presume a release, but I'm happy to do so.