try to get SQS queue before creating it #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments permissions for an IAM role or access key might not include "SQS create". The broker should first try to get the queue and if this fails try to create it as fall back to the current default behaviour.
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 91.18% 90.97% -0.21%
==========================================
Files 47 47
Lines 3051 3058 +7
==========================================
Hits 2782 2782
- Misses 269 276 +7
Continue to review full report at Codecov.
|
|
Thanks for the work on the SQS broker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments permissions for an IAM role or access key might not include "SQS create".
The broker should first try to get the queue and if this fails try to create it which matches the current default behaviour.