Add attempt_count to limit the number of times a filed task will be re-attempted

[timomeara]

Limit the number of retries for a failed task.

• add attempt_count = models.IntegerField(default=0) to Task model
• add attempt_count to configuration
• check value in cluster.save_task and acknowledge the task when attempt_count is > 0 and task.attempt_count == Conf.ATTEMPT_COUNT

[codecov-commenter]

Codecov Report

Merging #466 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   91.03%   91.18%   +0.15%     
==========================================
  Files          46       47       +1     
  Lines        3022     3051      +29     
==========================================
+ Hits         2751     2782      +31     
+ Misses        271      269       -2     

Impacted Files	Coverage Δ
django_q/tests/test_admin.py	100.00% <ø> (ø)
django_q/admin.py	98.14% <100.00%> (ø)
django_q/cluster.py	92.20% <100.00%> (+0.50%)	⬆️
django_q/conf.py	73.45% <100.00%> (+0.23%)	⬆️
django_q/migrations/0013_task_attempt_count.py	100.00% <100.00%> (ø)
django_q/models.py	98.22% <100.00%> (+0.01%)	⬆️
django_q/tests/test_cluster.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d0a8c...655f0aa. Read the comment docs.

[Koed00]

I'll review this in the next days. but I see you've been adding some more commits. Should I postpone reviewing it?

[timomeara]

I'll review this in the next days. but I see you've been adding some more commits. Should I postpone reviewing it?

cool!
no, no need to wait. that was me being stupid. i was playing w/ something else on the wrong branch.
that commit is reverted.

[Koed00]

Looks good. Thanks for the work on this. It was never on my priority list cause all the brokers I work with have their own max retry setting independent of django-q.

For now I would remove the attempt count from the fail admin, until at some point we have individual attempt counts per task.

[timomeara]

Looks good. Thanks for the work on this. It was never on my priority list cause all the brokers I work with have their own max retry setting independent of django-q.

For now I would remove the attempt count from the fail admin, until at some point we have individual attempt counts per task.

thanks-
i'll push that in a few
i added it to the admin because i thought it'd be useful in setups that have high attempt_count and retry values.
maybe a little addition to the readme that shows how to customize the admin would be nice

[Koed00]

You could also make it optional with a config setting for example. Or like you said; add some docs on how to customize the admin.

…

On Thu, Aug 13, 2020 at 4:21 PM timomeara ***@***.***> wrote: Looks good. Thanks for the work on this. It was never on my priority list cause all the brokers I work with have their own max retry setting independent of django-q. For now I would remove the attempt count from the fail admin, until at some point we have individual attempt counts per task. thanks- i'll push that in a few i added it to the admin because i thought it'd be useful in setups that have high attempt_count and retry values. maybe a little addition to the readme that shows how to customize the admin would be nice — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#466 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6AQNLE4CEPASQIQXGKFULSAPZHTANCNFSM4P3GSG6Q> .